lookingGlass: Let history trim input

Checking whether the item is empty is now the history’s job, per the
previous two commits. The history also trims the input for us.

The effect of this is that we call _history.addItem(), and thereby move
to the end of the history, even if the input is empty (or consists only
of whitespace); clearing the input field and pressing Enter becomes a
quick way to jump back to the end of the history. (The current history
item is not overwritten if the input is empty.)

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1653>

diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js
index 728983ea28b14595fa508179ee9149df420c8c6f..e59fa29306f13a71a4bcf5ad068445bfad2206ee 100644 (file)
--- a/js/ui/lookingGlass.js
+++ b/js/ui/lookingGlass.js
@@ -1129,10 +1129,6 @@ class LookingGlass extends St.BoxLayout {
             // Ensure we don't get newlines in the command; the history file is
             // newline-separated.
             text = text.replace('\n', ' ');
-            // Strip leading and trailing whitespace
-            text = text.replace(/^\s+/g, '').replace(/\s+$/g, '');
-            if (text == '')
-                return true;
             this._evaluate(text);
             return true;
         });
@@ -1240,7 +1236,9 @@ class LookingGlass extends St.BoxLayout {
     }
 
     _evaluate(command) {
-        this._history.addItem(command);
+        command = this._history.addItem(command); // trims command
+        if (!command)
+            return;
 
         let lines = command.split(';');
         lines.push('return %s'.format(lines.pop()));